Skip to content

Fix HttpResponseMessage disposal in mock test setups #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 2 commits into from
Feb 4, 2026
Merged

Fix HttpResponseMessage disposal in mock test setups #643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b63ff2
Initial plan
Copilot Feb 4, 2026
48aea3c
Fix HttpResponseMessage disposal issues in observability tests
Copilot Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/http/httpClient/HttpClientRequestAdapterObservabilityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ public async Task SendAsync_CreatesActivityWithUriTemplateTag()
.Setup<Task<HttpResponseMessage>>("SendAsync",
ItExpr.IsAny<HttpRequestMessage>(),
ItExpr.IsAny<System.Threading.CancellationToken>())
.ReturnsAsync(new HttpResponseMessage
.ReturnsAsync(() => new HttpResponseMessage
{
StatusCode = HttpStatusCode.OK,
Content = new StringContent("{\"id\":\"123\"}")
Expand Down Expand Up @@ -488,7 +488,7 @@ public async Task SendAsync_WithEmptyPath_SetsHttpRouteToRoot()
.Setup<Task<HttpResponseMessage>>("SendAsync",
ItExpr.IsAny<HttpRequestMessage>(),
ItExpr.IsAny<System.Threading.CancellationToken>())
.ReturnsAsync(new HttpResponseMessage
.ReturnsAsync(() => new HttpResponseMessage
{
StatusCode = HttpStatusCode.OK,
Content = new StringContent("{\"id\":\"123\"}")
Expand Down Expand Up @@ -537,7 +537,7 @@ public async Task SendAsync_SetsHttpRequestMethodTag()
.Setup<Task<HttpResponseMessage>>("SendAsync",
ItExpr.IsAny<HttpRequestMessage>(),
ItExpr.IsAny<System.Threading.CancellationToken>())
.ReturnsAsync(new HttpResponseMessage
.ReturnsAsync(() => new HttpResponseMessage
{
StatusCode = HttpStatusCode.OK,
Content = new StringContent("{\"id\":\"123\"}")
Expand Down Expand Up @@ -581,7 +581,7 @@ public async Task SendAsync_SetsUrlSchemeAndServerAddressTags()
.Setup<Task<HttpResponseMessage>>("SendAsync",
ItExpr.IsAny<HttpRequestMessage>(),
ItExpr.IsAny<System.Threading.CancellationToken>())
.ReturnsAsync(new HttpResponseMessage
.ReturnsAsync(() => new HttpResponseMessage
{
StatusCode = HttpStatusCode.OK,
Content = new StringContent("{\"id\":\"123\"}")
Expand Down Expand Up @@ -623,7 +623,7 @@ public async Task SendAsync_WithoutIncludeEUIIAttributes_DoesNotSetUrlFullTag()
.Setup<Task<HttpResponseMessage>>("SendAsync",
ItExpr.IsAny<HttpRequestMessage>(),
ItExpr.IsAny<System.Threading.CancellationToken>())
.ReturnsAsync(new HttpResponseMessage
.ReturnsAsync(() => new HttpResponseMessage
{
StatusCode = HttpStatusCode.OK,
Content = new StringContent("{\"id\":\"123\"}")
Expand Down Expand Up @@ -666,7 +666,7 @@ public async Task SendAsync_CreatesNestedActivitySpans()
.Setup<Task<HttpResponseMessage>>("SendAsync",
ItExpr.IsAny<HttpRequestMessage>(),
ItExpr.IsAny<System.Threading.CancellationToken>())
.ReturnsAsync(new HttpResponseMessage
.ReturnsAsync(() => new HttpResponseMessage
{
StatusCode = HttpStatusCode.OK,
Content = new StringContent("{\"id\":\"123\"}")
Expand Down
Loading
⚡