Handle sending path challenge on paths that have not resolved route yet#3545
Merged
Conversation
Collaborator
Author
|
Will take a look at the failures when I am back on Tuesday or Wednesday |
csujedihy
added
Area: Core
4 tasks
nibanks
reviewed
Apr 4, 2023
|
|
||
| #ifdef QUIC_USE_RAW_DATAPATH | ||
| // | ||
| // Make sure the route is resolved before sending the path challenge. |
Collaborator
There was a problem hiding this comment.
Any ideas on how? Could we make a test to explicitly trigger this?
Collaborator
Author
There was a problem hiding this comment.
You meant how a route is not resolved before sending the path challenge? Isn't this already covered by existing address rebind test cases? When we create a new path upon seeing a different source address from the peer, we create a path with an unresolved route.
nibanks
approved these changes
Apr 4, 2023
Collaborator
|
@csujedihy wasn't there a bug that could be closed along with this? |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It's possible that when sending a path challenge, the route is not yet resolved. We need to pause and resume path challenge when that happens.
Testing
CI