Skip to content

Fix underflow in ACK frame parsing#5942

Merged
guhetier merged 1 commit into
mainfrom
guhetier/underflow_fix
Apr 14, 2026
Merged

Fix underflow in ACK frame parsing#5942
guhetier merged 1 commit into
mainfrom
guhetier/underflow_fix

Conversation

@guhetier

Copy link
Copy Markdown
Collaborator

Description

Fix underflow in ACK frame parsing

Testing

CI

Documentation

NA

@guhetier guhetier requested a review from anrossi April 14, 2026 17:10
@codecov

codecov Bot commented Apr 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.68%. Comparing base (5e99ea7) to head (c3c5dae).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5942      +/-   ##
==========================================
- Coverage   84.73%   84.68%   -0.06%     
==========================================
  Files          60       60              
  Lines       18751    18754       +3     
==========================================
- Hits        15889    15882       -7     
- Misses       2862     2872      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guhetier guhetier merged commit 1e6e999 into main Apr 14, 2026
497 of 498 checks passed
@guhetier guhetier deleted the guhetier/underflow_fix branch April 14, 2026 20:44
guhetier added a commit that referenced this pull request Apr 14, 2026
## Description

Fix underflow in ACK frame parsing

## Testing

CI

## Documentation

NA

Co-authored-by: Sujeet Kumar <sujkum@microsoft.com>
guhetier added a commit that referenced this pull request Apr 14, 2026
## Description

Fix underflow in ACK frame parsing

## Testing

CI

## Documentation

NA

Co-authored-by: Sujeet Kumar <sujkum@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants