[CP] Default Windows CI builds to Visual Studio 18 2026 (#6100)#6104
Merged
Conversation
The windows-2025 runner image now ships VS 2026 instead of VS 2022. Update the default CMake generator to Visual Studio 18 2026 and add -Generator overrides for windows-2022 jobs that still use VS 2022. Changes: - build.ps1: default generator -> Visual Studio 18 2026 - build-reuse-win.yml: remove setup-perl (Perl preinstalled on runners), add -Generator conditional for windows-2022 - cargo.yml: remove setup-perl - test-down-level.yml: remove setup-perl, add -Generator conditional - external/CMakeLists.txt: add _DISABLE_OPTIONAL_ANNOTATION to fix VS 2026 STL annotation mismatch with ASan builds Cherry-pick of main commit bbd5db9 adapted for release/2.5. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
guhetier
changed the title
anrossi
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GitHub's
windows-2025andwindows-latesthosted runner images no longer ship Visual Studio 17 2022. Every Windows build job that targets those images currently fails with:This change:
Visual Studio 17 2022for jobs that are still pinned towindows-2022(which will soon be out of support).Testing
CI now succeeds
Documentation
docs/BUILD.mdgains a VS 2026 example block. No other doc impact.