Skip to content

Initial version#1

Merged
gramalingam merged 6 commits intomainfrom
rama/initial
Mar 2, 2022
Merged

Initial version#1
gramalingam merged 6 commits intomainfrom
rama/initial

Conversation

@gramalingam
Copy link
Copy Markdown
Collaborator

@gramalingam gramalingam commented Feb 28, 2022

Signed-off-by: Ganesan Ramalingam grama@microsoft.com

Any suggestions about the directory structure?

Right now it is:

onnxscript (main converter code)

test (testcases)
onnxscript (primitives to be used by onnxscript-code, like types etc.)

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@xadupre
Copy link
Copy Markdown
Member

xadupre commented Feb 28, 2022

I'll dig into that tomorrow. What about licence?

Comment thread onnxscript/analysis.py
@@ -0,0 +1,99 @@
import ast
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should put these file in a subfolder. functions would go in another.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I think in terms of code cleanup, there is a bunch of stuff to be done. In this PR, I am just focusing on the high-level directory structure, to get the initial version in.

@gramalingam
Copy link
Copy Markdown
Collaborator Author

I guess we need to worry about the license when we make it public? Not sure about the exact question, but open to suggestions.

Comment thread onnxscript/test/loop.py
@@ -0,0 +1,19 @@
from onnxscript.types import FLOAT, INT64
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these files are generated during tests, they should not be part of the repo.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are inputs to the test

Comment thread onnxscript/converter.py
import onnx
import onnx.helper as helper

print_flag = True
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use logging instead?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. But let me create the initial version, and then we can iterate through these improvements. (Identify them as tasks, and go from there.)

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@gramalingam gramalingam merged commit 034171b into main Mar 2, 2022
@gramalingam gramalingam deleted the rama/initial branch March 2, 2022 18:58
justinchuby added a commit that referenced this pull request Apr 2, 2026
Updated the security policy to include detailed reporting instructions
and preferred communication languages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants