Add support for _unsafe_index_put#1315
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1315 +/- ##
==========================================
- Coverage 78.68% 78.52% -0.17%
==========================================
Files 119 119
Lines 15762 15799 +37
Branches 2486 2500 +14
==========================================
+ Hits 12403 12406 +3
- Misses 2950 2980 +30
- Partials 409 413 +4 ☔ View full report in Codecov by Sentry. |
| reason="fixme: ORT only supports float32 when accumulate is True: MLFloat16 data type is not supported with ScatterND when reduction is 'add'", | ||
| ), | ||
| TorchLibOpInfo("ops.aten.index_put", core_ops.aten_index_put), | ||
| TorchLibOpInfo("ops.aten._unsafe_index_put", core_ops.aten__unsafe_index_put), |
There was a problem hiding this comment.
This op does not exist in extra_opinfo.py, so it will need to be created. Simply adding this entry to the file
opinfo_core.OpInfo(
"ops.aten._unsafe_index_put",
aten_name="_unsafe_index_put",
dtypes=common_dtype.floating_types(),
sample_inputs_func=sample_inputs_index_put,
supports_out=False,
),
will do
There was a problem hiding this comment.
I did but I don't really know what I'm doing so if you have a PR I could use as an example.
There was a problem hiding this comment.
Sure, https://github.com/microsoft/onnxscript/pull/1260/files and #1284 are good examples.
|
Tests errors in torch-nightly and onnx-weekly can be safely ignored. #1318 |
justinchuby
added
the
module: torchlib
2 participants
No description provided.