[torch api] Enable _TORCH_ONNX_SAVE_EXTERNAL_DATA_WITH_IR#1866
Merged
justinchuby merged 1 commit intomainfrom Sep 13, 2024
Merged
[torch api] Enable _TORCH_ONNX_SAVE_EXTERNAL_DATA_WITH_IR#1866justinchuby merged 1 commit intomainfrom
_TORCH_ONNX_SAVE_EXTERNAL_DATA_WITH_IR#1866justinchuby merged 1 commit intomainfrom
Conversation
Enable the `_TORCH_ONNX_SAVE_EXTERNAL_DATA_WITH_IR` flag to use the new external data logic. This will - Reduce peak memory usage - Align external data to 64k for the torch exporter.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
==========================================
+ Coverage 75.26% 75.42% +0.16%
==========================================
Files 251 251
Lines 27446 27446
Branches 5032 5032
==========================================
+ Hits 20656 20702 +46
+ Misses 5822 5778 -44
+ Partials 968 966 -2 ☔ View full report in Codecov by Sentry. |
gramalingam
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the
_TORCH_ONNX_SAVE_EXTERNAL_DATA_WITH_IRflag to use the new external data logic. This willfor the torch exporter.