Skip to content

[rewriter] Enable llama rule sets #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
titaiwangms merged 6 commits into from
Mar 24, 2025
Merged

[rewriter] Enable llama rule sets #2124

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77a7062
enable rule sets
titaiwangms Mar 24, 2025
debc998
delete overloapped no_op rules
titaiwangms Mar 24, 2025
8be6769
Merge branch 'main' into titaiwang/enable_more_rules
titaiwangms Mar 24, 2025
490b121
Merge branch 'main' into titaiwang/enable_more_rules
titaiwangms Mar 24, 2025
2a61151
fix bad imports
titaiwangms Mar 24, 2025
33966b1
fix tests
titaiwangms Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions onnxscript/optimizer/_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
cast_constant_of_shape,
collapse_slices,
gemm_to_matmul_add,
llama_rule_sets,
no_op,
)

Expand All @@ -23,6 +24,7 @@
gemm_to_matmul_add.rule,
*cast_constant_of_shape.rules.rules,
*collapse_slices.rules.rules,
*llama_rule_sets.llama_p0_rule_set().rules,
]


Expand Down
9 changes: 2 additions & 7 deletions onnxscript/rewriter/llama_rule_sets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import onnxscript.ir as ir
import onnxscript.rewriter._ir_utils as ir_utils
import onnxscript.rewriter.no_op as no_op
import onnxscript.rewriter.pattern as orp


Expand Down Expand Up @@ -292,15 +291,11 @@ def llama_p0_rule_set() -> orp.RewriteRuleSet:
"""
return orp.RewriteRuleSet(
[
no_op.mul_by_1_rule,
no_op.add_0_rule,
no_op.add_0_rule,
no_op.div_by_1_rule,
cast_cast_rule,
# cast_cast_rule, Might have precision issues.
cast_identity_rule,
expand_identity_rule,
reshape_reshape_rule,
slice_split_rule,
slice_split_rule, # Affect collapse slices rules?
transpose_identity_rule,
transpose_transpose_rule,
unsqueeze_unsqueeze_rule,
Expand Down
Loading
⚡