Skip to content

[passes] Remove external_data_folder option from FoldConstantsPass #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinchuby merged 2 commits into from
Apr 16, 2025
Merged

[passes] Remove external_data_folder option from FoldConstantsPass #2207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd1f3f8
[passes] Remove external_data_folder option from FoldConstantsPass
justinchuby Apr 16, 2025
6e82895
Fix call
justinchuby Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions onnxscript/optimizer/_constant_folding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,12 +843,10 @@ class FoldConstantsPass(ir.passes.InPlacePass):
def __init__(
self,
*,
external_data_folder: str,
shape_inference: bool,
input_size_limit: int,
output_size_limit: int,
) -> None:
self._external_data_folder = external_data_folder
self._shape_inference = shape_inference
self._input_size_limit = input_size_limit
self._output_size_limit = output_size_limit
Expand Down Expand Up @@ -1117,7 +1115,6 @@ def __bool__(self) -> bool:

def fold_constants(
model: ir.Model,
external_data_folder: str = "",
*,
onnx_shape_inference: bool = False,
input_size_limit: int = DEFAULT_CONSTANT_FOLD_INPUT_SIZE_LIMIT,
Expand All @@ -1128,8 +1125,6 @@ def fold_constants(

Args:
model: The ONNX model to optimize.
external_data_folder: Path to the folder containing external data
for the model. Defaults to an empty string.
onnx_shape_inference: Whether to enable ONNX shape inference during
constant folding. Defaults to False.
input_size_limit: The maximum size (in bytes) of input tensors
Expand All @@ -1144,7 +1139,6 @@ def fold_constants(

"""
folder_pass = FoldConstantsPass(
external_data_folder=external_data_folder,
shape_inference=onnx_shape_inference,
input_size_limit=input_size_limit,
output_size_limit=output_size_limit,
Expand Down
1 change: 0 additions & 1 deletion onnxscript/optimizer/_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ def optimize_ir(
ir.passes.PassManager(
[
_constant_folding.FoldConstantsPass(
external_data_folder="",
shape_inference=onnx_shape_inference,
input_size_limit=input_size_limit,
output_size_limit=output_size_limit,
Expand Down
Loading
⚡