Update proto comparison error message#2215
Merged
justinchuby merged 5 commits intomainfrom Apr 28, 2025
Merged
Conversation
❌ 16 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
gramalingam
reviewed
Apr 28, 2025
| a: google.protobuf.message.Message | Any, b: google.protobuf.message.Message | Any | ||
| actual: google.protobuf.message.Message | Any, | ||
| expected: google.protobuf.message.Message | Any, | ||
| ignore_initializer_value_proto: bool = False, |
Collaborator
There was a problem hiding this comment.
The ignore-initializer-value-proto seems a very specialized niche-case ... why/where exactly do you need it? Wonder if there is some more general-purpose mechanism to achieve that ... I don't have any suggestions at the moment though.
Collaborator
Author
There was a problem hiding this comment.
There are models in the onnx model zoo that does not have value info proto for initializers, but roundtripping will add those protos to the model. So I created a flag to ignore them. It is used in tools/ir/model_zoo_test/model_zoo_test.py
gramalingam
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update proto comparison error message to display all differences between two protos instead of failing at the first difference.