Formally drop python 3.8 support by justinchuby · Pull Request #2234 · microsoft/onnxscript

justinchuby · 2025-04-28T01:46:06Z

Python 3.8 has reached EOL.

codecov · 2025-04-28T01:49:40Z

❌ 35 Tests Failed:

Tests completed	Failed	Passed	Skipped
15020	35	14985	2703

View the top 3 failed test(s) by shortest run time

::onnxscript.function_libs.torch_lib.graph_building.__init__

Stack Traces | 0s run time

.../torch_lib/graph_building/__init__.py:44: in <module>
    from ._graph_building_torch import (
.../torch_lib/graph_building/_graph_building_torch.py:28: in <module>
    from onnxscript.function_libs.torch_lib.ops import common as common_ops
.../torch_lib/ops/__init__.py:16: in <module>
    from . import (
.../torch_lib/ops/core.py:961: in <module>
    def aten_atleast_1d_sequence(self: Sequence[TTensor]) -> TTensor:
.../function_libs/torch_lib/registration.py:131: in wrapper
    processed_func = onnxscript.script(opset=custom_opset)(func)
onnxscript/main.py:95: in transform
    result = script_check(f_ast, opset, env, src, default_opset=default_opset)
onnxscript/main.py:39: in script_check
    return convert.translate_function_def(f)
onnxscript/converter.py:1437: in translate_function_def
    fn_ir = self._translate_function_def_common(stmt)
onnxscript/converter.py:1422: in _translate_function_def_common
    _ = self._translate_function_signature_common(fn)
onnxscript/converter.py:1375: in _translate_function_signature_common
    if not ta.is_valid_type(typeinfo):
onnxscript/type_annotation.py:187: in is_valid_type
    return is_value_type(typeinfo) in {True, False}
onnxscript/type_annotation.py:145: in is_value_type
    if _is_tensor_type(typeinfo):
onnxscript/type_annotation.py:135: in _is_tensor_type
    if inspect.isclass(typeinfo) and issubclass(typeinfo, onnx_types.TensorType):
.../Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/abc.py:123: in __subclasscheck__
    return _abc_subclasscheck(cls, subclass)
E   TypeError: issubclass() arg 1 must be a class

::onnxscript.function_libs.torch_lib.ops.special

Stack Traces | 0s run time

....../Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1027: in _find_and_load
    ???
<frozen importlib._bootstrap>:992: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:241: in _call_with_frames_removed
    ???
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1027: in _find_and_load
    ???
<frozen importlib._bootstrap>:1006: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:688: in _load_unlocked
    ???
<frozen importlib._bootstrap_external>:883: in exec_module
    ???
<frozen importlib._bootstrap>:241: in _call_with_frames_removed
    ???
.../torch_lib/ops/__init__.py:16: in <module>
    from . import (
.../torch_lib/ops/core.py:40: in <module>
    from onnxscript.function_libs.torch_lib.ops import common as common_ops
.../torch_lib/ops/__init__.py:16: in <module>
    from . import (
.../torch_lib/ops/core.py:961: in <module>
    def aten_atleast_1d_sequence(self: Sequence[TTensor]) -> TTensor:
.../function_libs/torch_lib/registration.py:131: in wrapper
    processed_func = onnxscript.script(opset=custom_opset)(func)
onnxscript/main.py:95: in transform
    result = script_check(f_ast, opset, env, src, default_opset=default_opset)
onnxscript/main.py:39: in script_check
    return convert.translate_function_def(f)
onnxscript/converter.py:1437: in translate_function_def
    fn_ir = self._translate_function_def_common(stmt)
onnxscript/converter.py:1422: in _translate_function_def_common
    _ = self._translate_function_signature_common(fn)
onnxscript/converter.py:1375: in _translate_function_signature_common
    if not ta.is_valid_type(typeinfo):
onnxscript/type_annotation.py:187: in is_valid_type
    return is_value_type(typeinfo) in {True, False}
onnxscript/type_annotation.py:145: in is_value_type
    if _is_tensor_type(typeinfo):
onnxscript/type_annotation.py:135: in _is_tensor_type
    if inspect.isclass(typeinfo) and issubclass(typeinfo, onnx_types.TensorType):
....../Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/abc.py:123: in __subclasscheck__
    return _abc_subclasscheck(cls, subclass)
E   TypeError: issubclass() arg 1 must be a class

::onnxscript.function_libs.torch_lib.ops.vision

Stack Traces | 0s run time

....../Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1027: in _find_and_load
    ???
<frozen importlib._bootstrap>:992: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:241: in _call_with_frames_removed
    ???
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1027: in _find_and_load
    ???
<frozen importlib._bootstrap>:1006: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:688: in _load_unlocked
    ???
<frozen importlib._bootstrap_external>:883: in exec_module
    ???
<frozen importlib._bootstrap>:241: in _call_with_frames_removed
    ???
.../torch_lib/ops/__init__.py:16: in <module>
    from . import (
.../torch_lib/ops/core.py:40: in <module>
    from onnxscript.function_libs.torch_lib.ops import common as common_ops
.../torch_lib/ops/__init__.py:16: in <module>
    from . import (
.../torch_lib/ops/core.py:961: in <module>
    def aten_atleast_1d_sequence(self: Sequence[TTensor]) -> TTensor:
.../function_libs/torch_lib/registration.py:131: in wrapper
    processed_func = onnxscript.script(opset=custom_opset)(func)
onnxscript/main.py:95: in transform
    result = script_check(f_ast, opset, env, src, default_opset=default_opset)
onnxscript/main.py:39: in script_check
    return convert.translate_function_def(f)
onnxscript/converter.py:1437: in translate_function_def
    fn_ir = self._translate_function_def_common(stmt)
onnxscript/converter.py:1422: in _translate_function_def_common
    _ = self._translate_function_signature_common(fn)
onnxscript/converter.py:1375: in _translate_function_signature_common
    if not ta.is_valid_type(typeinfo):
onnxscript/type_annotation.py:187: in is_valid_type
    return is_value_type(typeinfo) in {True, False}
onnxscript/type_annotation.py:145: in is_value_type
    if _is_tensor_type(typeinfo):
onnxscript/type_annotation.py:135: in _is_tensor_type
    if inspect.isclass(typeinfo) and issubclass(typeinfo, onnx_types.TensorType):
....../Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/abc.py:123: in __subclasscheck__
    return _abc_subclasscheck(cls, subclass)
E   TypeError: issubclass() arg 1 must be a class

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

Copilot

Pull Request Overview

This PR formally drops Python 3.8 support by updating type annotations to use built‐in generic types and related modern idioms. Key changes include:

Replacing Legacy typing generics (e.g. Tuple, List, Dict) with built‐in alternatives (e.g. tuple, list, dict) and updated imports from collections.abc.
Consistent conversion of type hints across multiple files in the codebase to align with Python 3.9+ standards.

Reviewed Changes

Copilot reviewed 79 out of 79 changed files in this pull request and generated no comments.

File	Description
onnxscript/function_libs/torch_lib/ops/core.py	Updated type hint return types from Tuple[...] to tuple[...]
onnxscript/function_libs/torch_lib/graph_building/_graph_building_torch.py	Converted multiple type hints (Tuple, Dict, List) to built‐in generics and adjusted import sources
onnxscript/function_libs/tools/torch_lib/*.py	Changed usage of legacy typing generics to their built‐in versions (e.g. list, dict, etc.)
onnxscript/_internal/*.py and others	Updated type annotations and related imports to reflect modern Python syntax

justinchuby · 2025-05-29T16:44:11Z

Replaced by #2354

… of set for output_nodes Replace set[NodePattern] with dict[NodePattern, None] to preserve deterministic insertion order from the outputs sequence. Python sets have non-deterministic iteration order due to hash randomization, which caused the multi-output pattern matching to behave differently across runs. Fixes #2234 Agent-Logs-Url: https://github.com/microsoft/onnxscript/sessions/50f46d7a-beee-47c4-9369-3c28417380d1 Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com>

Formally drop python 3.8 support

68f97f3

github-project-automation Bot added this to ONNX Script Review Board Apr 28, 2025

github-project-automation Bot moved this to Todo in ONNX Script Review Board Apr 28, 2025

justinchuby requested a review from titaiwangms April 28, 2025 01:46

justinchuby enabled auto-merge (squash) April 28, 2025 01:46

justinchuby added the topic: build label Apr 28, 2025

justinchuby mentioned this pull request Apr 28, 2025

python3.8 support #2233

Closed

Update converter.py

a258172

justinchuby requested a review from xadupre April 28, 2025 01:51

py

d65d0c7

justinchuby disabled auto-merge April 28, 2025 01:57

justinchuby added 4 commits April 27, 2025 19:01

Format

7116f36

format

e29256f

lint

ed5e1b8

lint

442b9c5

justinchuby commented Apr 28, 2025

View reviewed changes

Comment thread onnxscript/converter.py Outdated

justinchuby added 3 commits April 28, 2025 09:59

Fix ast

4d6ea34

Merge branch 'main' into justinchu/py38

227f0e9

debugging

bbe99cb

justinchuby marked this pull request as draft April 28, 2025 17:15

justinchuby added 5 commits April 28, 2025 11:55

Merge branch 'main' into justinchu/py38

9cf61cf

update

2f8aab4

GenericAlias

e29d8c6

test

1fa8c11

type

bcecabe

justinchuby marked this pull request as ready for review April 28, 2025 19:02

justinchuby marked this pull request as draft April 28, 2025 19:14

justinchuby added 2 commits April 28, 2025 13:07

format

be33f0a

GenericAlias

51cb8e1

justinchuby added 5 commits April 28, 2025 13:34

err

8d158cc

Sequence

72d481a

update

23e74d5

_is_tensor_type

735e4a9

constraints

2173b6b

justinchuby requested a review from Copilot April 28, 2025 20:48

Copilot AI reviewed Apr 28, 2025

View reviewed changes

justinchuby added topic: breaking changes and removed topic: build labels Apr 28, 2025

justinchuby added 4 commits April 28, 2025 13:51

Fix

bdde8bc

abc

bb04839

true

18dc886

typeinfo

e383fd7

justinchuby marked this pull request as ready for review April 28, 2025 23:05

justinchuby marked this pull request as draft April 28, 2025 23:05

justinchuby added this to the 0.3 milestone Apr 30, 2025

Merge branch 'main' into justinchu/py38

1b6b4a1

OYCN mentioned this pull request May 19, 2025

Inconsistent use of generics in type hints causes issues in Python 3.8 #2313

Closed

justinchuby closed this May 29, 2025

github-project-automation Bot moved this from Todo to Done in ONNX Script Review Board May 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Formally drop python 3.8 support#2234

Formally drop python 3.8 support#2234
justinchuby wants to merge 27 commits intomainfrom
justinchu/py38

justinchuby commented Apr 28, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Apr 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

justinchuby commented May 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

justinchuby commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 35 Tests Failed:

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

justinchuby commented May 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

justinchuby commented Apr 28, 2025 •

edited

Loading

codecov Bot commented Apr 28, 2025 •

edited

Loading