Rewrite Skip fusions with check functions#2259
Merged
shubhambhokare1 merged 4 commits intomainfrom May 2, 2025
Merged
Conversation
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
justinchuby
approved these changes
May 1, 2025
justinchuby
reviewed
May 1, 2025
gramalingam
reviewed
May 1, 2025
d82adcb to
b54e320
Compare
justinchuby
approved these changes
May 2, 2025
5 tasks
shubhambhokare1
added a commit
that referenced
this pull request
May 7, 2025
Add fusion rules to support the optimization of Whisper models.
Fusions added:
- Basic Fusions:
* additional pattern for erfgelu [moved to #2222]
- SkipLayerNorm:
* #2259
* Fusion patterns where skip_sum is also an output
* Bias + SkipLayerNorm -> SkipLayerNorm (with bias) [moved to #2222]
- BiasGelu Fusion [moved to #2222]
- SDPA:
* Support for pattern where only q is pre-scaled
- MHA:
* Patterns with/without past/present keys/values
* Patterns with non-rotary embeddings
* Patterns with/without mask
* Patterns with cross-attention (only for past key/value patterns)
- MHA Bias Fusion:
* Bias was offloaded to Attention fusion previously, this fusion fixes
that
- Attention:
* Patterns where Q, K and V do not come from slicing
TODO:
- [x] Fix SDPA singular prescale case, due to lost shape information
- [x] - Enable check conditions when #2210 is merged
- [x] - Improve/Rewrite whisper model test case to be similar to that of
smollm (for eg)
- [x] - Fix failing test cases to account for new patterns
- [x] - Add isolated test cases for new fusions like BiasGelu,
SkipLayerNorm etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fusion support patterns with:
Add(input, skip) -> NormAdd(input, skip) -> Add (result, bias) -> NormAdd(input, bias) -> Add (result, skip) -> NormNOTE:
These fusions should support: