[Rewriter(matmul_add_to_gemm)]: check shapes#2528
Merged
justinchuby merged 1 commit intomicrosoft:mainfrom Aug 28, 2025
Merged
Conversation
Ensure that input shapes are not None before checking their rank. Used _ir_utils.has_rank to handle this safely.
justinchuby
approved these changes
Aug 28, 2025
justinchuby
reviewed
Aug 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2528 +/- ##
=======================================
Coverage 70.01% 70.01%
=======================================
Files 215 215
Lines 25988 25989 +1
Branches 2606 2606
=======================================
+ Hits 18195 18196 +1
Misses 6895 6895
Partials 898 898 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we need to check the rank of input shapes, we need to ensure that input shapes are not None before checking their rank. Used
_ir_utils.has_rankto handle that.