[Rewriter] Add fuse batchnorm to default rules#2553
Merged
justinchuby merged 3 commits intomicrosoft:mainfrom Sep 9, 2025
Merged
[Rewriter] Add fuse batchnorm to default rules#2553justinchuby merged 3 commits intomicrosoft:mainfrom
justinchuby merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds batch normalization fusion rules to the default rewriter rules, enabling automatic optimization of BatchNorm patterns during model rewriting.
- Refactors
_fuse_batchnorm.pyto use class variables instead of constructor parameters - Adds the fuse_batchnorm rules to the default optimization rules in
__init__.py
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| onnxscript/rewriter/rules/common/_fuse_batchnorm.py | Refactors classes to use ClassVar for op_type and removes constructors |
| onnxscript/rewriter/init.py | Imports and includes _fuse_batchnorm rules in default optimization rules |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2553 +/- ##
==========================================
- Coverage 70.34% 70.34% -0.01%
==========================================
Files 218 218
Lines 26430 26424 -6
Branches 2647 2647
==========================================
- Hits 18593 18587 -6
Misses 6934 6934
Partials 903 903 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
fuse_batchnormrules to default rules.