Skip to content

[torchlib] Fix aten_gather to correctly handle scalar indices#2566

Merged
justinchuby merged 1 commit intomicrosoft:mainfrom
linshokaku:aten_gather_scalar_index
Sep 18, 2025
Merged

[torchlib] Fix aten_gather to correctly handle scalar indices#2566
justinchuby merged 1 commit intomicrosoft:mainfrom
linshokaku:aten_gather_scalar_index

Conversation

@linshokaku
Copy link
Copy Markdown
Contributor

Fixes #2564

Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Comment thread onnxscript/function_libs/torch_lib/ops/core.py
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Sep 17, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.32%. Comparing base (f529292) to head (57cbb4e).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
onnxscript/function_libs/torch_lib/ops/core.py 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2566      +/-   ##
==========================================
- Coverage   70.33%   70.32%   -0.01%     
==========================================
  Files         222      222              
  Lines       26656    26659       +3     
  Branches     2666     2667       +1     
==========================================
+ Hits        18748    18749       +1     
- Misses       6992     6993       +1     
- Partials      916      917       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby added this to the 0.5.2 milestone Sep 17, 2025
@justinchuby justinchuby merged commit 3156bed into microsoft:main Sep 18, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: torchlib Related to the torch/aten function lib in development

Projects

Development

Successfully merging this pull request may close these issues.

behavior discrepancy when aten::gather receives a scalar index

2 participants