Closed
Conversation
Closed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2690 +/- ##
==========================================
- Coverage 70.09% 68.90% -1.20%
==========================================
Files 228 217 -11
Lines 27382 21916 -5466
Branches 2783 2256 -527
==========================================
- Hits 19194 15101 -4093
+ Misses 7229 6007 -1222
+ Partials 959 808 -151 ☔ View full report in Codecov by Sentry. |
Collaborator
|
@Aravind-11 I triggered CI. could you rebase? Thanks |
Aravind-11
force-pushed
the
fix-2219-new
branch
from
ba2439e to
de31158
Compare
Contributor
Author
Done 🤗 |
justinchuby
requested changes
Jan 1, 2026
Collaborator
justinchuby
left a comment
justinchuby
left a comment
There was a problem hiding this comment.
ok. I don't think this change is desirable, since it has reverted a lot of new changes we made. Also #2549 has been merged. Thanks for taking the time to open a PR though!
github-project-automation
Bot
moved this from Todo
to In Progress
in ONNX Script Review Board
Contributor
Author
|
Thank you! Closing this pr. |
github-project-automation
Bot
moved this from In Progress
to Done
in ONNX Script Review Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr works on top of the previous pr #2549 . Hi @justinchuby , could you point me to the tests that I should run for this ? Thanks a lot!