fix(fuse_batchnorm): support convtranpose + bn fusion with group != 1#2879
Merged
gramalingam merged 1 commit intomicrosoft:mainfrom Apr 10, 2026
Merged
Conversation
justinchuby
approved these changes
Apr 2, 2026
Collaborator
|
Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes BatchNormalization fusion for grouped ConvTranspose so that optimization no longer crashes (broadcast/reshape mismatch) when group != 1, addressing #2867.
Changes:
- Implement group-aware weight scaling for
ConvTranspose+ BatchNormalization fusion. - Add a guard to skip fusion for semantically invalid grouped
ConvTranspose(whenin_channels % group != 0). - Expand tests to cover grouped
Conv/ConvTransposefusion and the invalid-model skip case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
onnxscript/rewriter/rules/common/_fuse_batchnorm.py |
Refactors weight scaling and adds correct grouped ConvTranspose handling + validation to avoid reshape/broadcast failures. |
onnxscript/rewriter/rules/common/_fuse_batchnorm_test.py |
Extends unit tests for grouped fusion behavior and adds a regression test for invalid grouped ConvTranspose. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2879 +/- ##
=======================================
Coverage 71.96% 71.97%
=======================================
Files 239 239
Lines 29224 29251 +27
Branches 2878 2880 +2
=======================================
+ Hits 21031 21053 +22
- Misses 7216 7219 +3
- Partials 977 979 +2 ☔ View full report in Codecov by Sentry. |
gramalingam
approved these changes
Apr 10, 2026
justinchuby
pushed a commit
that referenced
this pull request
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2867