fix(chromium): insert oopifs into the frame hierarchy when connecting over CDP#37359
Merged
Conversation
… over CDP Previously, the information of the parent frame for an OOPIF target was not available over CDP. With the latest Chromium, we can finally determine where does the OOPIF fit in the frame hierarchy.
Contributor
Test results for "tests 1"4 flaky46774 passed, 821 skipped Merge workflow run. |
yury-s
approved these changes
Sep 9, 2025
|
|
||
| private _addBrowserListeners() { | ||
| this._eventListeners.push(...[ | ||
| eventsHelper.addEventListener(this._client, 'Target.attachedToTarget', event => this._onAttachedToTarget(event)), |
Member
There was a problem hiding this comment.
Is this compatible with chromium <141 ?
Collaborator
Author
There was a problem hiding this comment.
Yes, these events were always coming from the browser.
| if (!frame && event.targetInfo.parentFrameId) { | ||
| // When connecting to an existing page with an iframe, there is an "iframe" target, | ||
| // but no local frame is reported in getFrameTree. We can create a remote frame here. | ||
| frame = this._page.frameManager.frameAttached(targetId, event.targetInfo.parentFrameId); |
Member
There was a problem hiding this comment.
Could it be that the parent frame has not been reported yet/has been removed already at this point?
Collaborator
Author
There was a problem hiding this comment.
Targets come from the browser target and the source of truth. If the frame is removed, we'll get Target.detachedFromTarget shortly after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the information of the parent frame for an OOPIF target was not available over CDP. With the latest Chromium, we can finally determine where does the OOPIF fit in the frame hierarchy.
Fixes #17656.