chore: add post-version step to Nx Release#2418
Merged
Conversation
Collaborator
|
EDIT: This is because dry-run doesn't commit the files, so the generator fails. I'll move forward with this knowing that caveat. I did a quick test by cherry-picking this to a local branch off 0.77-stable, and added these logging statements: Which resulted in this output: It seems to be picking up the old version because the new version hasn't been committed yet? Alternatively, we could use nx's releaseVersion function (which is part of their public API) to get the new version as I do in #2417: |
Saadnajmi
reviewed
Mar 17, 2025
Saadnajmi
approved these changes
Mar 17, 2025
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 17, 2025
Adds a post-version step to Nx Release for updating generated artifacts (e.g., `RCTVersion.m`). Bump the version and run `nx release`: ``` yarn nx release plan --only-touched=false patch yarn nx release --skip-publish --verbose ``` Verify that generated artifacts have been updated with the latest version number. --------- Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 17, 2025
Adds a post-version step to Nx Release for updating generated artifacts (e.g., `RCTVersion.m`). Bump the version and run `nx release`: ``` yarn nx release plan --only-touched=false patch yarn nx release --skip-publish --verbose ``` Verify that generated artifacts have been updated with the latest version number. --------- Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
Saadnajmi
added a commit
that referenced
this pull request
Mar 17, 2025
Saadnajmi
added a commit
that referenced
this pull request
Mar 17, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a post-version step to Nx Release for updating generated artifacts (e.g.,
RCTVersion.m).Test Plan:
Bump the version and run
nx release:Verify that generated artifacts have been updated with the latest version number.