Skip to content

ci: update preid check in prepublish.mjs #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Saadnajmi merged 3 commits into from
Mar 25, 2025
Merged

ci: update preid check in prepublish.mjs #2432

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70742ff
ci(0.78): update prepublish check to check prerelease existence
Saadnajmi Mar 24, 2025
9349ce7
Fix preid validation in prepublish-check script
Saadnajmi Mar 24, 2025
1f4db0c
Add generatorOptions to version string check
Saadnajmi Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ado/scripts/prepublish-check.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ function enablePublishing(config, currentBranch, { npmTag: tag, prerelease, isNe

// Determines whether we need to add "nightly" or "rc" to the version string.
const { generatorOptions } = release.version;
if (generatorOptions.preid !== prerelease) {
if (prerelease && generatorOptions.preid !== prerelease) {
Comment thread
Saadnajmi marked this conversation as resolved.
Outdated
errors.push(`'release.version.generatorOptions.preid' must be set to '${prerelease || ""}'`);
if (prerelease) {
generatorOptions.preid = prerelease;
Expand Down
Loading
⚡