fix: suppress warning around a constructor function#2840
Merged
Saadnajmi merged 1 commit intomicrosoft:mainfrom Feb 26, 2026
Merged
fix: suppress warning around a constructor function#2840Saadnajmi merged 1 commit intomicrosoft:mainfrom
Saadnajmi merged 1 commit intomicrosoft:mainfrom
Conversation
Xcode 26.4 now warns about functions annotated as constructors if the -Wglobal-constructors flag is enabled. We want that on as an error by default so that we don't trivially get new ones added, but we need to suppress the warning around existing code. Add this to ReactNative.
|
Saadnajmi
changed the title
Saadnajmi
approved these changes
Feb 26, 2026
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 10, 2026
## Summary: Xcode 26.4 now warns about functions annotated as constructors if the -Wglobal-constructors flag is enabled. We want that on as an error by default so that we don't trivially get new ones added, but we need to suppress the warning around existing code. Add this to ReactNative. <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> ## Test Plan No testing needed; this only suppresses a compiler warning in a narrow location. <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. -->
Saadnajmi
added a commit
that referenced
this pull request
Mar 12, 2026
Backport #2840 Co-authored-by: Erik Schwiebert <eriksc@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Xcode 26.4 now warns about functions annotated as constructors if the -Wglobal-constructors flag is enabled. We want that on as an error by default so that we don't trivially get new ones added, but we need to suppress the warning around existing code. Add this to ReactNative.
Test Plan
No testing needed; this only suppresses a compiler warning in a narrow location.