Skip to content

Unfork utils/jsi files in ReactCommon #12891

@TatianaKapos

Description

@TatianaKapos

Problem Description

Recent integration brings in PR: https://github.com/facebook/react-native/pull/42801/files#diff-ff466c93fb60f2b0e79ed187f492c9935349a2b2f2a7300b310e2bb30e31c33e which creates a new jsi.h and jsi.cpp file in ReactCommon. On windows, even though the files have different paths, MSVC doesn't allow two files to have the same name in the same project. Currently have a PR upstream to fix it: facebook/react-native#43700.

Steps To Reproduce

  1. Remove override
  2. ReactCommon will break

Expected Results

No response

CLI version

npx react-native -v

Environment

npx react-native info

Target Platform Version

10.0.19041

Target Device(s)

Desktop

Visual Studio Version

Visual Studio 2022

Build Configuration

Debug

Snack, code example, screenshot, or link to a repository

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions