-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Add mouse navigation button support for actions #10802
Copy link
Copy link
Open
Labels
Area-TerminalControlIssues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.)Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.)Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.The new Windows Terminal.
Milestone
Metadata
Metadata
Assignees
Labels
Area-TerminalControlIssues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.)Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.)Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.The new Windows Terminal.
Description of the new feature/enhancement
Follow-up on #10801: the added
browser_backand_forwardkeys are the keyboard keys, not the mouse buttons. It might be nice to add support for these buttons as well, usually they areVK_XBUTTON1andVK_XBUTTON2.Proposed technical implementation details (optional)
The implementation will be a bit more complicated than just adding the key definitions, as now the mouse handlers should also check for keychord bindings. My proposal would be to add this to
TermControl::_PointerPressedHandler. This would limit the support to when hovering the terminal control, so that might not be ideal. I am not sure what is actually desirable here.Things to consider:
browser_backand_forward, or separate namesmouse_backand_forward?