Feature Request: Command Palette

[yasintz]

Summary of the new feature/enhancement

In Profile.json we will define the actions section.

This section is an array and each element takes an Object, the schema can be

{
  "icon" : "...",
  "title" : "...",
  "command": "..."
}

You can add an icon next to the icons at the top right and make the following features.

• A list will open.

• Using the information in actions in Profile.json, it will create the elements of the list and execute a command when we click on it.
  I'm leaving a picture to make it more descriptive.
  

Edit : Where can we find a complete list of shortcut commands that we can use on the Windows-terminal? If there is no such place, is it possible to share in pdf or website form?

[mdtauk]

I think a list of common commands assigned to each profile, which displays as a toolbar, may be a better way. It also means the list of commands will be relevant to the profile, so no Bash commands while in Powershell.

[yasintz]

I think a list of common commands assigned to each profile, which displays as a toolbar, may be a better way. It also means the list of commands will be relevant to the profile, so no Bash commands while in Powershell.

Are you talking about something like that? @mdtauk

[mdtauk]

I think a list of common commands assigned to each profile, which displays as a toolbar, may be a better way. It also means the list of commands will be relevant to the profile, so no Bash commands while in Powershell.

Are you talking about something like that? @mdtauk

Those actions/commands seem more suited to a context menu, as they are specific to the Windows Terminal - I was thinking something more like

"commands": [
      {
            "icon": "appx:\\icons\\windows.png",
            "title": "WinVer",
            "command": "winver.exe"
      },
      {
            "icon": "appx:\\icons\\clear.png",
            "title": "Clear Screen",
            "command": "cls"
      }
      ],
],

[michael-hawker]

Would you want to duplicate the commands section per profile, or keep the icon/title the same in a central list but be able to conditionally show them based on environment or run different commands based on the environment (e.g. being able to specify cls for cmd and clear for WSL, and if you're in PS then it wouldn't appear).

[zadjii-msft]

Okay so this seems like it's getting close to a grab bag of feature requests. Lemme try and break this thread down so far:

• We want a button to display the available commands (that could be bound to keybindings) and execute them from that UI.
• We want "actions" in the profiles.json that define these actions for the UI
• We want a possible type of "action" to be "execute this command" (which is going to end up being implemented as "send this text to the terminal as input (with or without a newline)")
• We want a way of conditionally defining the scope of these actions, so they could appear in some profiles and not others.

Now, what I'll add is this immediately made me think of the Command Palette in VsCode and Sublime:

What if we added to that list:

• Be able to fuzzy-search for commands/actions by name
• Add a keybinding to display this UI
• Add a setting to show/hide a button to bring up this UI

---

Now, lets get into some nitty-gritty details. Lets stick to just the existing keybinding commands for now. If we wanted to later add a "inputCommand" keybinding we could, but I think that's definitely blocked on work in #1142 /#1349, where we can add an arbitrary commandline to the command. I'm also going to scope this discussion to have only a global list of actions. Keybindings are global only currently, so let's just make actions global too, and save per-profile keybindings and actions for another thread.

We could theoretically define default actions for all the existing keybinding commands. With #754, we could add all the commands (that make sense) as actions to the actions list, so that everyone wouldn't need to define them manually.

An Action would be defined similarly to how you have it above:

class Action
{
    winrt::hstring Name();
    winrt::TerminalApp::ShortcutAction Command();
    winrt::hstring IconPath();
}

We'd need another structure in GlobalAppSettings to hold all these actions. I guess it could just be a std::vector<Action> in GlobalAppSettings. We'll need to make sure to roundtrip serialize them. We'll need app to be able to turn this vector into a ListView or something of actions, so that it can display this list of actions. Each element in the view would need to be intrinsically associated with the Action object it's associated with. If Action isn't a winrt type, this might be a bit more painful, but it'll mean we'll need another class to do all the serializing of them, but that's a pattern we're already using so great. Action should be a winrt type: winrt::TerminalApp::Action (maybe needs a better name).

When an element is clicked on in the list of actions, we'll need to somehow raise the event corresponding to that ShortcutAction. AppKeyBindings already does a great job of dispatching ShortcutActions, so lets re-use that. We'll pull the basic parts of dispatching ShortcutAction callbacks into another class, ShortcutActionDispatch, with a single DoAction(ShortcutAction) (name WIP) method (and events for each action). AppKeybindings will be initialized with a reference to the ShortcutActionDispatch object, so that it can call DoAction on it.

In App, when someone clicks on an item in the list, we'll get the ShortcutAction associated with that list element, and call DoAction on the app's ShortcutActionDispatch.

</spec>

[zadjii-msft]

oh no I accidentally the whole thing

It's certainly not polished enough to ship how it is. We might not want to ship it at all in 1.0 honestly. It would need a lot of work, starting with polishing the above comment into a proper spec. But it's certainly super neat.