This is a follow-up from PR #4429, and bug #2455
I actually don't hate the idea of just duplicating the settings for the existing control. In that scenario, we'd probably just ignore the settings for that profile in the actual file, and just use whatever settings the control currently has. This might require some plumbing, but it's doable.
Okay this is harder, but maybe not impossible, but probably impossible in v1.
The Profile knows how to build the connection settings, and the ControlSettings, etc. However, when the settings reloads like in this bug, we'll remove all the old profiles, and build a new list.
If we wanted the case 1 behavior, we could wait until the Profile is a winrt object, then have each Pane hold a strong ref to the Profile that it's hosting. Then it would be trivial to be able to duplicate the settings from it. I believe that work is tracked in #3998.
As of #4429, we'll silently do nothing. We should instead get the Profile from the Pane/Tab that we're duplicating, and use that to build the settings instead.
note to self: this is the "duplicate the NewTerminalArgs, not just the Profile" thread
This is a follow-up from PR #4429, and bug #2455
As of #4429, we'll silently do nothing. We should instead get the
Profilefrom thePane/Tabthat we're duplicating, and use that to build the settings instead.note to self: this is the "duplicate the
NewTerminalArgs, not just the Profile" thread