Dynamic Profile Generator for Windows PowerShell

[TBBle]

Description of the new feature/enhancement

It'd be nice if the "Windows PowerShell" profile worked like the other profiles, and could be disabled using disabledProfileSources.

This would remove the need to carry a 'hidden' overriding profile per #5459, as disabledProfileSources made possible for the other profile sources.

Proposed technical implementation details (optional)

I guess it just needs new IDynamicProfileGenerator implementation, that replaces (and slurps up?) the existing Windows PowerShell profile if present, which appears to have a fixed GUID ({61c54bbd-c2c6-5271-96e7-009a87ff44bf}), fix the 'pick a default profile' logic, and then remove it from the defaults.json.

If the same thing is done for CMD, then I guess the risk appears of how to handle the case that there are no profiles available, where right now I guess you always have those two profiles, even if somehow they are not usable.

[DHowett-MSFT]

Before I get to triaging this for real, just wanted to throw out a comment;

even if somehow they are not usable.

If powershell and cmd are not usable on your machine, you are in a very sorry state. Many things on your system will cease to function. I'm not sure this is a reasonable state to be in. 😄

[DHowett-MSFT]

You know, I thought I hated this. I actually don't think I do, which ... makes me somewhat sad. 😆

My stance was always that Windows PowerShell is a windows inbox application, which means we don't need to produce it with a dynamic profile generator. We wanted there to always be a reasonable default so that it would take real effort to get Terminal into a state where it doesn't have any profiles (suppressing all the generators, hiding them all, etc.).

I dunno. @zadjii-msft, this might actually make sense as part of the powershell generator. We can detect the Windows one, the Core ones, and we can actually include the Windows one in the sorted preferential list. I dunno.

I'm marking this one up for issue-task on the backlog, but it warrants further discussion.

[TBBle]

I think the same idea applies to the CMD profile. To me, the big advantage of this is consistency in how you manage profiles, both disabling and for when we get #3818 to support overriding.

The flag for me was that there was necessary clarifying around the behaviour of source in a profile, but that set of rationales and behaviours can't be applied to the two "in-box" shells, even (especially) when you're in the position that those two shells are no longer interesting to be run directly in a terminal.