Implement OSC 7 for setting the CWD by lhecker · Pull Request #20019 · microsoft/terminal

lhecker · 2026-03-25T20:55:58Z

This adds support for OSC 7 which is the same as OSC 9;9 but using
file URIs. As per the previous discussion in #8214, the problem is
that WSL shells emit URIs that can't work because the hostname in
the URI translates to an UNC path with an non-existing hostname.
In my opinion this doesn't deter the fact though that OSC 7 works
just fine for a native Windows application.

In the future we should consider trying to detect WSL file URIs
and translating it to the --cd argument for wsl.exe.

All of the heavy lifting for parsing the URI is done by
PathCreateFromUrlW. It just had to be plugged into the OSC 9;9 code.

Closes #3158

Validation Steps Performed

Launch fish-shell in WSL
Duplicate tab works ✅
(And because it doesn't work without using
IsValidDirectory I know that OSC 7 works ✅)

carlos-zamora

Looks good! Just the minor comments and it looks like you need to run the code formatter. I'll circle back to this then.

src/common.build.pre.props

src/types/utils.cpp

carlos-zamora

DHowett

blocking to think about my opinion

DHowett · 2026-03-30T17:50:31Z

src/terminal/adapter/adaptDispatch.cpp

+    // and the resulting path can never be longer than the URI.
+    const auto ptr = path.data();
+    auto len = gsl::narrow<DWORD>(path.size());
+    THROW_IF_FAILED(PathCreateFromUrlW(ptr, ptr, &len, 0));


this will add a dependency from conhost on the library containing PathCreateFromUrlW; is that acceptable?

.... it's in kernelbase?

api-ms-win-core-url-l1-1-0 PathCreateFromUrlW

hmm where are you hosted little guy

> $d.Apis["PathCreateFromUrlW"][1].Binary Architecture : Amd64 BinplacePath : kernelbase.dll

wellp

DHowett · 2026-03-30T17:59:55Z

src/cascadia/TerminalControl/ControlCore.cpp


-    winrt::hstring ControlCore::CurrentWorkingDirectory() const
-    {
-        return winrt::hstring{ _terminal->GetWorkingDirectory() };


i s2g, we just had a whole-ass duplicate of this function?

Yeah lol. I was super surprised about that too. We don't have skeletons in our basement, we got entire graveyards apparently lmao.

DHowett · 2026-03-30T18:00:19Z

src/types/utils.cpp

+    }
+
+    WIN32_FILE_ATTRIBUTE_DATA data;
+    const auto ok = GetFileAttributesExW(path, GetFileExInfoStandard, &data);


instead of std::filesystem::access or whatever? cool w/ me

Yeah, I just hate that the std::filesystem::path objects are expensive to construct. Under the hood, it gets passed to __std_fs_get_stats, which - and you will never guess this - takes a null-terminated string. 🤦‍♂️

Hurr durr "C++ is for low level zero overhead real man's man engineering."
Meanwhile: Wrap in wstring to unwrap in pointer. lmao

This adds support for OSC 7 which is the same as OSC 9;9 but using file URIs. As per the previous discussion in #8214, the problem is that WSL shells emit URIs that can't work because the hostname in the URI translates to an UNC path with an non-existing hostname. In my opinion this doesn't deter the fact though that OSC 7 works just fine for a native Windows application. In the future we should consider trying to detect WSL file URIs and translating it to the `--cd` argument for `wsl.exe`. All of the heavy lifting for parsing the URI is done by `PathCreateFromUrlW`. It just had to be plugged into the OSC 9;9 code. Closes #3158 ## Validation Steps Performed * Launch fish-shell in WSL * Duplicate tab works ✅ * (And because it doesn't work without using `IsValidDirectory` I know that OSC 7 works ✅) (cherry picked from commit 4ce79d7) Service-Card-Id: PVTI_lADOAF3p4s4BQX0-zgpBLe8 Service-Version: 1.25

austin-beer · 2026-04-06T13:25:20Z

I just updated to version 1.25.923.0 (a Friday servicing release: https://github.com/microsoft/terminal/releases/tag/v1.25.923.0 😃). I currently use OSC 9;9 to set the CWD. It appears that that is now broken. Was that intentional?

lhecker · 2026-04-06T15:28:23Z

@austin-beer Be more specific when reporting issues please. OSC 9;9 + Duplicate Tab works as expected for me.

DHowett · 2026-04-06T15:31:27Z

Unfortunately I was also unable to repro any breakage here! There might be some additional conditions we aren't aware of 😅

DHowett · 2026-04-06T15:33:53Z

The only difference for OSC 9;9 is that we now check whether the target directory truly is accessible as a directory before spawning a process there.

If somebody was smuggling Linux paths in via OSC 9;9, it may have worked previously, but it would have been out of spec.

DHowett · 2026-04-06T16:14:06Z

Chatting with Leonard a bit more, we have some ideas on how to make this less terrible for everyone.

austin-beer · 2026-04-06T18:24:08Z

Okay, yes, I am providing Linux paths, not Windows paths, so that's why it's now broken for me. I need to change my command prompt to use the documented approach that converts to Windows paths first, correct?

DHowett · 2026-04-06T18:47:58Z

That'll fix it for now while we evaluate how best to fix it for everyone. Thanks for using Preview! :)

Implement OSC 7 for setting the CWD

7a84c10

carlos-zamora approved these changes Mar 27, 2026

View reviewed changes

src/common.build.pre.props Outdated Show resolved Hide resolved

src/types/utils.cpp Outdated Show resolved Hide resolved

lhecker and others added 2 commits March 30, 2026 18:30

Address feedback

1a3c2a4

Format

bd5116a

carlos-zamora approved these changes Mar 30, 2026

View reviewed changes

carlos-zamora enabled auto-merge (squash) March 30, 2026 17:40

DHowett requested changes Mar 30, 2026

View reviewed changes

microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 30, 2026

DHowett reviewed Mar 30, 2026

View reviewed changes

microsoft-github-policy-service bot removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 30, 2026

DHowett approved these changes Mar 30, 2026

View reviewed changes

carlos-zamora merged commit 4ce79d7 into main Mar 30, 2026
18 of 20 checks passed

carlos-zamora deleted the dev/lhecker/3158-osc7 branch March 30, 2026 18:10

DHowett added this to 1.25 Servicing Pipeline Apr 3, 2026

github-project-automation bot moved this to To Cherry Pick in 1.25 Servicing Pipeline Apr 3, 2026

DHowett moved this from To Cherry Pick to Cherry Picked in 1.25 Servicing Pipeline Apr 3, 2026

lhecker mentioned this pull request Apr 8, 2026

Implement UNC path mangling for OSC 7 via WSL #20094

Open

Conversation

lhecker commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Validation Steps Performed

Uh oh!

carlos-zamora left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

carlos-zamora left a comment

Choose a reason for hiding this comment

Uh oh!

DHowett left a comment

Choose a reason for hiding this comment

Uh oh!

DHowett Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

DHowett Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

DHowett Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

DHowett Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

DHowett Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

lhecker Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

DHowett Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

lhecker Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

austin-beer commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lhecker commented Apr 6, 2026

Uh oh!

DHowett commented Apr 6, 2026

Uh oh!

DHowett commented Apr 6, 2026

Uh oh!

DHowett commented Apr 6, 2026

Uh oh!

austin-beer commented Apr 6, 2026

Uh oh!

DHowett commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lhecker commented Mar 25, 2026 •

edited

Loading

lhecker Mar 30, 2026 •

edited

Loading

austin-beer commented Apr 6, 2026 •

edited

Loading