Merged
Conversation
ghost
added
Area-Commandline
ghost
closed this
Member
Author
|
Oh, so one the target branch was closed, this can't get re-targeted anymore? That's... good to know |
zadjii-msft
changed the base branch from
dev/migrie/f/288-launchMode-fullscreen
to
master
Member
|
I just saw that GitHub had a new feature that automatically changed branch targeting if you did this, so I wonder why it didn’t work |
miniksa
approved these changes
Jun 1, 2020
…screen # Conflicts: # src/cascadia/TerminalApp/TerminalPage.cpp
ghost
requested review from
carlos-zamora
approved these changes
Jun 1, 2020
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This was referenced Jun 12, 2020
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds two new flags to the
wt.exealias:--maximized,-M: Launch the new Terminal window maximized. This flag cannot be combined with--fullscreen.--fullscreen,-F: Launch the new Terminal window fullscreen. This flag cannot be combined with--maximized.References
launchMode#6060.PR Checklist
Detailed Description of the Pull Request / Additional comments
I had to move the commandline arg parsing up a layer from
TerminalPagetoAppLogic, becauseAppLogiccontrols the Terminal's settings, including launch mode settings. This seems like a reasonable change, to put both the settings from the file and the commandline in the same place."What happens when you try to pass both flags, like
wtd -M -F new-tab?":Validation Steps Performed