Add support for unstructured masks in MaskAnalysis#333
Merged
bmyerz0 merged 4 commits intomicrosoft:mainfrom Sep 3, 2025
Merged
Add support for unstructured masks in MaskAnalysis#333bmyerz0 merged 4 commits intomicrosoft:mainfrom
bmyerz0 merged 4 commits intomicrosoft:mainfrom
Conversation
- Enhanced `MaskAnalysis` to handle generic masks. MaskState will save generic mask for a dimension if that dimension failed MaskAnalysis. - Updated `TritonStructuredDialect` to include `gather_scatter_mask` in `MakeGatherScatterTensorPtrOp`. - Modified `PtrAnalysis` to apply generic masks during pointer analysis. - Extended `StructuredToMemref` conversion to support generic masks in load/store operations. - Added verification logic for `MakeGatherScatterTensorPtrOp` to ensure compatibility with masks.
bmyerz0
reviewed
Aug 27, 2025
bmyerz0
reviewed
Aug 27, 2025
added 2 commits
August 29, 2025 15:11
Also fix the offset divide stride issue when convert tts::MakeTensorPtrOp to tts::MakeGatherScatterTensorPtrOp.
python3kgae
changed the title
bmyerz0
reviewed
Sep 2, 2025
bmyerz0
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaskAnalysisto handle unstructured masks. MaskState will save unstructured mask for a dimension if that dimension failed MaskAnalysis.TritonStructuredDialectto includegather_scatter_maskinMakeGatherScatterTensorPtrOp.PtrAnalysisto apply unstructured masks during pointer analysis.StructuredToMemrefconversion to support generic masks in load/store operations.MakeGatherScatterTensorPtrOpto ensure compatibility with masks.