Remove triton submodule and add triton-hash.txt to track the triton commit ID#344
Conversation
|
Now that we are cloning the Triton repo, should we add the folder to the gitignore here? |
|
Does this change require any edits to the nightly pipeline? Nightly pipeline pulls down Triton main. (I am working on fixing the nightly pipeline at the moment which has separate issues when integrating with Triton main right now). |
red1bluelost
left a comment
There was a problem hiding this comment.
Looks mostly good to me. Just some comments. I am adding Meta and Qualcomm folks to the review.
|
Seems I cannot add non-Microsoft reviewers so just tagging folks in this comment. @haishanzzzz, @mitekoth, @zhaoshiz |
|
@lechenyu Right now we have three symlinks into Triton: 'python/examples/test_core.py', 'python/examples/test_annotations.py', and '.clang-format'. For the clang-format, I'd be fine with having a copy in our repo. I doubt it would change in a way we care about. For the two test files, we need a way to import them into examples so they can be tested. |
Apologies for missing those symlinks. I was thinking it might be helpful to set up a top-level CMakeLists.txt to automate the build process. Since we're trying to remove the Triton submodule, there are now several additional steps that users need to be aware of, such as checking out Triton manually and making the two Python test visible to triton-shared. |
|
I’ve updated the CMakeLists.txt to automatically generate the three symlinks. These symlinks are now included in .gitignore. |
This PR removes the Triton submodule and replaces it with a hash file (
triton-hash.txt) to track the Triton version. This change provides greater flexibility in the Triton versions that triton-shared can be built with. All relevant files have been updated accordingly.After this PR is landed, the installation steps will be