Skip to content

Setup clang-format action and format the whole codebase.#349

Merged
red1bluelost merged 2 commits intomicrosoft:mainfrom
red1bluelost:setup-clang-format-action
Sep 3, 2025
Merged

Setup clang-format action and format the whole codebase.#349
red1bluelost merged 2 commits intomicrosoft:mainfrom
red1bluelost:setup-clang-format-action

Conversation

@red1bluelost
Copy link
Copy Markdown
Contributor

This PR does the following:

  • Clang-Formats all C and C++ files within our repository using the LLVM style.
  • Creates a github workflow that will verify code formatting on PRs.
  • Removes symlink of clang-format in favor of a permanent copy. We do not care to keep it up to date with Triton. The likelihood of Triton updating their clang format file is low enough for this to not be a problem. Even if it were updated, it is not essential for us to fully match their style. It is more important to have a permanent copy that keeps the workflows simple.

Copy link
Copy Markdown

@NathanielMcVicar NathanielMcVicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent! I have some very nitty comments on the github action.

Comment thread .github/workflows/clang-format.yml Outdated
Comment thread .github/workflows/clang-format.yml Outdated
Comment thread .github/workflows/clang-format.yml Outdated
Copy link
Copy Markdown

@NathanielMcVicar NathanielMcVicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@red1bluelost red1bluelost enabled auto-merge (squash) September 3, 2025 18:03
@red1bluelost red1bluelost merged commit 9a32209 into microsoft:main Sep 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants