Skip to content

Wrap all error messages in PtrAnalysis and MaskAnalysis in LLVM_DEBUG#357

Merged
red1bluelost merged 4 commits intomicrosoft:mainfrom
nhat-nguyen:main
Oct 8, 2025
Merged

Wrap all error messages in PtrAnalysis and MaskAnalysis in LLVM_DEBUG#357
red1bluelost merged 4 commits intomicrosoft:mainfrom
nhat-nguyen:main

Conversation

@nhat-nguyen
Copy link
Copy Markdown
Contributor

Change all instances of emitError to emitRemark in PtrAnalysis and MaskAnalysis while also wrapping them in LLVM_DEBUG to prevent confusion to users. These errors should already gracefully handled by triton-shared and should be used for debugging purposes only.

Copy link
Copy Markdown
Contributor

@bmyerz0 bmyerz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I know this has been confusing to users

@nhat-nguyen
Copy link
Copy Markdown
Contributor Author

@nhat-nguyen please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="Meta"]

@nhat-nguyen
Copy link
Copy Markdown
Contributor Author

@nhat-nguyen the command you issued was incorrect. Please try again.

Examples are:

@microsoft-github-policy-service agree

and

@microsoft-github-policy-service agree company="your company"

@microsoft-github-policy-service agree company="Meta"

@red1bluelost red1bluelost merged commit 3f29c9e into microsoft:main Oct 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants