Wrap all error messages in PtrAnalysis and MaskAnalysis in LLVM_DEBUG#357
Merged
red1bluelost merged 4 commits intomicrosoft:mainfrom Oct 8, 2025
Merged
Wrap all error messages in PtrAnalysis and MaskAnalysis in LLVM_DEBUG#357red1bluelost merged 4 commits intomicrosoft:mainfrom
red1bluelost merged 4 commits intomicrosoft:mainfrom
Conversation
bmyerz0
approved these changes
Oct 3, 2025
Contributor
bmyerz0
left a comment
There was a problem hiding this comment.
Thanks - I know this has been confusing to users
Contributor
Author
@microsoft-github-policy-service agree [company="Meta"] |
Contributor
Author
@microsoft-github-policy-service agree company="Meta" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change all instances of
emitErrortoemitRemarkinPtrAnalysisandMaskAnalysiswhile also wrapping them inLLVM_DEBUGto prevent confusion to users. These errors should already gracefully handled by triton-shared and should be used for debugging purposes only.