Fix TritonSan build error#359
Merged
lechenyu merged 3 commits intomicrosoft:mainfrom Oct 27, 2025
Merged
Conversation
bmyerz0
requested changes
Oct 25, 2025
bmyerz0
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the TritonSan build error. The build script was broken due to several issues:
Removal of the Triton submodule: We now use triton-hash.txt to record the Triton version. The previous logic for locating Triton submodule was invalidated by this change.
LLVM-related issue: In the corresponding LLVM version, there is a known bug that causes a compilation error when building OpenMP. The build script now cherry-picks this patch to address the problem.
This PR fixes all these issues. The build script will now automatically check out Triton and place it alongside triton-shared, LLVM, and the Python virtual environment. There are no changes to the usage of the build script or the TritonSan driver script.