Deprecate @list decorator in favor of rest's @listsResource#2093
Deprecate @list decorator in favor of rest's @listsResource#2093daviwil merged 6 commits intomicrosoft:mainfrom
@list decorator in favor of rest's @listsResource#2093Conversation
daviwil
requested review from
allenjzhang,
bterlson,
markcowl,
nguerrera and
timotheeguerin
as code owners
daviwil
force-pushed
the
move-list-decorator
branch
from
87e56e3 to
56f81fe
Compare
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://cadlwebsite.z1.web.core.windows.net/prs/2093/ |
daviwil
force-pushed
the
move-list-decorator
branch
from
56f81fe to
4abea6c
Compare
daviwil
force-pushed
the
move-list-decorator
branch
from
4abea6c to
2e201c7
Compare
| ``` | ||
|
|
||
|
|
||
| ### `@list` {#@list} |
There was a problem hiding this comment.
that is unfortunate that we get the doc now that it is deprecated
There was a problem hiding this comment.
It'd be nice if the deprecation notice came through with it. The only other option is to just take out the extern definition and put the exception for @list back into library-linter, but is that worse?
There was a problem hiding this comment.
yeah I guess that is dependent on the design meeting that was inconclusive last week :(
| @@ -118,7 +118,7 @@ describe("rest: routes", () => { | |||
| @autoRoute | |||
There was a problem hiding this comment.
@lmazuel do we want to talk about this deprecation, this was an undocumented decorator in the compiler that was only used internally in the rest library.
There was a problem hiding this comment.
Any thoughts on this?
There was a problem hiding this comment.
probably just bring it up in the DPG meeting today at 11
There was a problem hiding this comment.
Sounds like folks are OK with this one going in!
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
2 participants
This change fixes #1978 by deprecating the virtually-unused
@listdecorator in favor of the@listsResourcedecorator in@typespec/rest. I'm also deprecating the associatedisListOperationandgetListOperationTypefunctions in@typespec/compilerand movingisListOperationto the REST library.The corresponding
typespec-azurePR is here: Azure/typespec-azure#3200