Remove the 'Edit Secret Name..." command (#501)

* Add placeholder

* Remove edit secret name

* Small changes

Author: motm32

package.json

@@ -130,11 +130,6 @@
                 "title": "%containerApps.addSecret%",
                 "category": "Azure Container Apps"
             },
-            {
-                "command": "containerApps.editSecretName",
-                "title": "%containerApps.editSecretName%",
-                "category": "Azure Container Apps"
-            },
             {
                 "command": "containerApps.editSecretValue",
                 "title": "%containerApps.editSecretValue%",
@@ -473,11 +468,6 @@
                     "when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /secretsItem/i",
                     "group": "1@1"
                 },
-                {
-                    "command": "containerApps.editSecretName",
-                    "when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /secretItem/i",
-                    "group": "1@1"
-                },
                 {
                     "command": "containerApps.editSecretValue",
                     "when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /secretItem/i",

package.nls.json

@@ -19,7 +19,6 @@
     "containerApps.toggleVisibility": "Switch Ingress Visibility...",
     "containerApps.editTargetPort": "Edit Target Port...",
     "containerApps.addSecret": "Add Secret...",
-    "containerApps.editSecretName": "Edit Secret Name...",
     "containerApps.editSecretValue": "Edit Secret Value...",
     "containerApps.deleteSecret": "Delete Secret...",
     "containerApps.chooseRevisionMode": "Choose Revision Mode...",

src/commands/registerCommands.ts

@@ -37,7 +37,6 @@ import { addScaleRule } from './scaling/scaleRule/addScaleRule/addScaleRule';
 import { deleteScaleRule } from './scaling/scaleRule/deleteScaleRule/deleteScaleRule';
 import { addSecret } from './secret/addSecret/addSecret';
 import { deleteSecret } from './secret/deleteSecret/deleteSecret';
-import { editSecretName } from './secret/editSecret/editSecretName';
 import { editSecretValue } from './secret/editSecret/editSecretValue';
 
 export function registerCommands(): void {
@@ -73,7 +72,6 @@ export function registerCommands(): void {
 
     // secret
     registerCommandWithTreeNodeUnwrapping('containerApps.addSecret', addSecret);
-    registerCommandWithTreeNodeUnwrapping('containerApps.editSecretName', editSecretName);
     registerCommandWithTreeNodeUnwrapping('containerApps.editSecretValue', editSecretValue);
     registerCommandWithTreeNodeUnwrapping('containerApps.deleteSecret', deleteSecret);
 

…ds/secret/editSecret/SecretUpdateStep.ts …cret/editSecret/SecretValueUpdateStep.tssrc/commands/secret/editSecret/SecretUpdateStep.ts renamed to src/commands/secret/editSecret/SecretValueUpdateStep.ts src/commands/secret/editSecret/SecretUpdateStep.ts renamed to src/commands/secret/editSecret/SecretValueUpdateStep.ts

@@ -3,36 +3,27 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { AzureWizardExecuteStep, nonNullProp, nonNullValue } from "@microsoft/vscode-azext-utils";
+import { AzureWizardExecuteStep, nonNullProp } from "@microsoft/vscode-azext-utils";
 import type { Progress } from "vscode";
 import { ext } from "../../../extensionVariables";
 import { ContainerAppModel, getContainerEnvelopeWithSecrets } from "../../../tree/ContainerAppItem";
 import { localize } from "../../../utils/localize";
 import { updateContainerApp } from "../../updateContainerApp";
 import type { ISecretContext } from "../ISecretContext";
 
-export class SecretUpdateStep extends AzureWizardExecuteStep<ISecretContext> {
+export class SecretValueUpdateStep extends AzureWizardExecuteStep<ISecretContext> {
     public priority: number = 850;
 
     public async execute(context: ISecretContext, progress: Progress<{ message?: string | undefined; increment?: number | undefined }>): Promise<void> {
         const containerApp: ContainerAppModel = nonNullProp(context, 'containerApp');
         const containerAppEnvelope = await getContainerEnvelopeWithSecrets(context, context.subscription, containerApp);
 
-        let updatedSecret: string | undefined;
-        if (context.newSecretName) {
-            context.activityTitle = localize('updatingSecretName', 'Update secret name from "{0}" to "{1}" in container app "{2}"', context.secretName, context.newSecretName, containerApp.name);
-            updatedSecret = localize('updatedSecretName', 'Updated secret name from "{0}" to "{1}" in container app "{2}".', context.secretName, context.newSecretName, containerApp.name);
-        } else if (context.newSecretValue) {
-            updatedSecret = localize('updatedSecretValue', 'Updated secret value for "{0}" in container app "{1}".', context.secretName, containerApp.name);
-        }
-
         progress.report({ message: localize('updatingSecret', 'Updating secret...') });
 
         let didUpdateSecret: boolean = false;
         containerAppEnvelope.configuration.secrets ||= [];
         containerAppEnvelope.configuration.secrets.forEach((secret) => {
             if (secret.name === context.secretName) {
-                secret.name = context.newSecretName ?? secret.name;
                 secret.value = context.newSecretValue ?? secret.value;
                 didUpdateSecret = true;
             }
@@ -44,10 +35,10 @@ export class SecretUpdateStep extends AzureWizardExecuteStep<ISecretContext> {
 
         await updateContainerApp(context, context.subscription, containerAppEnvelope);
 
-        ext.outputChannel.appendLog(nonNullValue(updatedSecret));
+        ext.outputChannel.appendLog(localize('updatedSecretValue', 'Updated secret value for "{0}" in container app "{1}".', context.secretName, containerApp.name));
     }
 
     public shouldExecute(context: ISecretContext): boolean {
-        return !!context.secretName && (!!context.newSecretName || !!context.newSecretValue);
+        return !!context.secretName && !!context.newSecretValue;
     }
 }

src/commands/secret/editSecret/editSecretName.ts

@@ -11,7 +11,7 @@ import { localize } from "../../../utils/localize";
 import { pickSecret } from "../../../utils/pickItem/pickSecret";
 import type { ISecretContext } from "../ISecretContext";
 import { SecretValueStep } from "../addSecret/SecretValueStep";
-import { SecretUpdateStep } from "./SecretUpdateStep";
+import { SecretValueUpdateStep } from "./SecretValueUpdateStep";
 
 export async function editSecretValue(context: IActionContext, node?: SecretItem): Promise<void> {
     const item: SecretItem = node ?? await pickSecret(context);
@@ -32,7 +32,7 @@ export async function editSecretValue(context: IActionContext, node?: SecretItem
     ];
 
     const executeSteps: AzureWizardExecuteStep<ISecretContext>[] = [
-        new SecretUpdateStep()
+        new SecretValueUpdateStep()
     ];
 
     const wizard: AzureWizard<ISecretContext> = new AzureWizard(wizardContext, {