Conversation
motm32
changed the title
Contributor
Author
|
After some discussion with Anthony we decided it was better to remove "Edit Secret Name..." all together. |
MicroFish91
approved these changes
Oct 18, 2023
| public async prompt(context: ISecretContext): Promise<void> { | ||
| context.newSecretName = (await context.ui.showInputBox({ | ||
| prompt: localize('secretName', 'Enter a secret name.'), | ||
| placeHolder: context.secretName ?? localize('emptyPlaceholder', ''), |
Contributor
There was a problem hiding this comment.
Nit: We can probably remove the placeHolder since we won't be editing existing secret names anymore
| context.activityTitle = localize('updatingSecretName', 'Update secret name from "{0}" to "{1}" in container app "{2}"', context.secretName, context.newSecretName, containerApp.name); | ||
| updatedSecret = localize('updatedSecretName', 'Updated secret name from "{0}" to "{1}" in container app "{2}".', context.secretName, context.newSecretName, containerApp.name); | ||
| } else if (context.newSecretValue) { | ||
| if (context.newSecretValue) { |
Contributor
There was a problem hiding this comment.
An alternative that might make more sense now that we won't be updating secret names anymore - maybe we can just rename this entire step to something like SecretValueUpdateStep? Then we could drop the if statement entirely so that it just always runs that section of code when the step is called
Contributor
There was a problem hiding this comment.
Oh can probably also remove let updatedSecret... (line 21/23) and move the string down to the bottom where it's used now as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #475 and #489