Wip

Author: MicroFish91

src/commands/editContainerApp.ts

@@ -11,11 +11,9 @@ import { localize } from "../utils/localize";
 import { pickContainerApp } from "../utils/pickContainerApp";
 
 export async function editContainerApp(context: IActionContext, node?: ContainerAppItem): Promise<void> {
-    node ??= await pickContainerApp(context);
-
-    if (node.containerApp.revisionsMode !== KnownActiveRevisionsMode.Single) {
-        throw new Error(localize('revisionModeError', 'The issued command can only be executed when the container app is in single revision mode.'));
-    }
-
+    node ??= await pickContainerApp(context, {
+        title: localize('selectContainerApp', 'Select a Container App in Single Revisions Mode'),
+        revisionsMode: KnownActiveRevisionsMode.Single
+    });
     await ext.revisionDraftFileSystem.editRevisionDraft(node);
 }

src/utils/pickContainerApp.ts

@@ -3,9 +3,11 @@
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/
 
-import { AzureResourceQuickPickWizardContext, AzureWizardPromptStep, ContextValueQuickPickStep, IActionContext, QuickPickAzureResourceStep, QuickPickAzureSubscriptionStep, QuickPickGroupStep, ResourceGroupsItem, runQuickPickWizard } from "@microsoft/vscode-azext-utils";
+import { KnownActiveRevisionsMode } from "@azure/arm-appcontainers";
+import { AzureResourceQuickPickWizardContext, AzureWizardPromptStep, ContextValueQuickPickStep, IActionContext, QuickPickAzureResourceStep, QuickPickAzureSubscriptionStep, QuickPickGroupStep, ResourceGroupsItem, nonNullValue, runQuickPickWizard } from "@microsoft/vscode-azext-utils";
 import { AzExtResourceType } from "@microsoft/vscode-azureresources-api";
 import * as vscode from 'vscode';
+import { revisionModeMultipleContextValue, revisionModeSingleContextValue } from "../constants";
 import { ext } from "../extensionVariables";
 import { ContainerAppItem } from "../tree/ContainerAppItem";
 import { ManagedEnvironmentItem } from "../tree/ManagedEnvironmentItem";
@@ -15,6 +17,10 @@ export interface PickItemOptions {
     title?: string;
 }
 
+export interface ContainerAppPickItemOptions extends PickItemOptions {
+    revisionsMode?: KnownActiveRevisionsMode;
+}
+
 function getPickEnvironmentSteps(tdp: vscode.TreeDataProvider<unknown>): AzureWizardPromptStep<AzureResourceQuickPickWizardContext>[] {
     const types = [AzExtResourceType.ContainerAppsEnvironment];
     return [
@@ -26,25 +32,36 @@ function getPickEnvironmentSteps(tdp: vscode.TreeDataProvider<unknown>): AzureWi
             resourceTypes: types,
             skipIfOne: false,
         }, {
-            placeHolder: localize('selectContainerAppsEnvironment', 'Select Container Apps Environment'),
+            placeHolder: localize('selectContainerAppsEnvironment', 'Select a container apps environment'),
         }),
     ];
 }
 
-export async function pickContainerApp(context: IActionContext, options?: PickItemOptions): Promise<ContainerAppItem> {
+export async function pickContainerApp(context: IActionContext, options?: ContainerAppPickItemOptions): Promise<ContainerAppItem> {
     return await containerAppExperience<ContainerAppItem>(context, ext.rgApiV2.resources.azureResourceTreeDataProvider, options);
 }
 
-export async function containerAppExperience<TPick>(context: IActionContext, tdp: vscode.TreeDataProvider<ResourceGroupsItem>, options?: PickItemOptions): Promise<TPick> {
+export async function containerAppExperience<TPick>(context: IActionContext, tdp: vscode.TreeDataProvider<ResourceGroupsItem>, options?: ContainerAppPickItemOptions): Promise<TPick> {
+    const contextFilter: RegExp[] | undefined = [ContainerAppItem.contextValueRegExp];
+    let noPicksMessage: string | undefined;
+
+    if (options?.revisionsMode === KnownActiveRevisionsMode.Single) {
+        contextFilter.push(new RegExp(revisionModeSingleContextValue));
+        noPicksMessage = localize('noSingleRevisionApps', 'Selected environment has no container apps in single revisions mode.');
+    } else if (options?.revisionsMode === KnownActiveRevisionsMode.Multiple) {
+        contextFilter.push(new RegExp(revisionModeMultipleContextValue));
+        noPicksMessage = localize('noMultipleRevisionApps', 'Selected environment has no container apps in multiple revisions mode.');
+    }
+
     return await runQuickPickWizard(context, {
         promptSteps: [
             ...getPickEnvironmentSteps(tdp),
             new ContextValueQuickPickStep(tdp, {
-                contextValueFilter: { include: ContainerAppItem.contextValueRegExp },
+                contextValueFilter: { include: nonNullValue(contextFilter) },
                 skipIfOne: true,
             }, {
-                placeHolder: localize('selectContainerApp', 'Select Container App'),
-                noPicksMessage: localize('noContainerApps', 'Selected Container Apps Environment has no Apps'),
+                placeHolder: localize('selectContainerApp', 'Select a container app'),
+                noPicksMessage: noPicksMessage ?? localize('noContainerApps', 'Selected environment has no container apps.'),
             }),
         ],
         title: options?.title,