Add command for deploying to ACA from Docker extension#212
Merged
bwateratmsft merged 8 commits intomainfrom Feb 7, 2023
Merged
Add command for deploying to ACA from Docker extension#212bwateratmsft merged 8 commits intomainfrom
bwateratmsft merged 8 commits intomainfrom
Conversation
bwateratmsft
commented
Oct 11, 2022
bwateratmsft
commented
Oct 11, 2022
nturinski
reviewed
Oct 12, 2022
Member
nturinski
left a comment
nturinski
left a comment
There was a problem hiding this comment.
Everything looks good than the TODO. Did you want to merge or were you going to finish it up first?
Contributor
Author
@nturinski it needs to be finished. I should have created this as a draft. |
Contributor
Author
|
I think this is ready to go. @nturinski can you take a look? Me and @MicroFish91 authored it so I wouldn't consider a signoff from either of us to be "valid" 😄 |
Member
|
If anyone else besides Docker starts consuming this in the future, I'd like to have a more robust API surface than just a command. At a minimum typings, but maybe even a package like we did for RGs. |
alexweininger
approved these changes
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #209.