Merged
Conversation
bwateratmsft
approved these changes
Jan 30, 2023
|
|
||
| type ResourceGroupsItem = TreeElementBase & { id: string }; | ||
|
|
||
| export class TreeItemStateStore implements vscode.Disposable { |
Contributor
There was a problem hiding this comment.
Seems like we should do some code sharing with this class/file.
Member
Author
There was a problem hiding this comment.
Yes. I will put an implementation in utils. Planning on making it cover our use cases, but allow for clients to extend if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apart from the commands which don't have picking support, everything should be working as expected. I will leave that for CTI to determine, but I've tested most things as I went pretty diligently.
Todos are marked with
// TODOcomments (I know I'm a genius 🤓)The largest todos are: