Skip to content

Refactor createContainerApp to use the new deploy base pattern#283

Merged
MicroFish91 merged 3 commits intomainfrom
mwf/create-refactor
Mar 9, 2023
Merged

Refactor createContainerApp to use the new deploy base pattern#283
MicroFish91 merged 3 commits intomainfrom
mwf/create-refactor

Conversation

@MicroFish91
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/commands/createContainerApp/ImageSourceListStep.ts Outdated
@MicroFish91 MicroFish91 marked this pull request as ready for review March 9, 2023 06:06
@MicroFish91 MicroFish91 requested a review from a team as a code owner March 9, 2023 06:06
@MicroFish91
Copy link
Copy Markdown
Contributor Author

MicroFish91 commented Mar 9, 2023

Additional Changes

  • Migrated ImageSourceListStep to live within deploy/ and changed its context typing to use IDeployBaseContext since the underlying steps are based around/tied to the deploy image scenarios...

@MicroFish91 MicroFish91 force-pushed the mwf/create-refactor branch from dca72e8 to 7b68589 Compare March 9, 2023 18:33
@MicroFish91 MicroFish91 force-pushed the mwf/create-refactor branch from 7b68589 to ecb61f5 Compare March 9, 2023 18:51
@MicroFish91 MicroFish91 merged commit 2a0cc09 into main Mar 9, 2023
@MicroFish91 MicroFish91 deleted the mwf/create-refactor branch March 9, 2023 19:39
@MicroFish91
Copy link
Copy Markdown
Contributor Author

Fixes #276

As of this PR (3/3)...

@MicroFish91 MicroFish91 mentioned this pull request Mar 9, 2023
@MicroFish91 MicroFish91 linked an issue Mar 9, 2023 that may be closed by this pull request
@microsoft microsoft locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor deployImage

3 participants