Suggest values during steps when deploying image from ACR#305
Merged
MicroFish91 merged 10 commits intomainfrom Mar 28, 2023
Merged
Suggest values during steps when deploying image from ACR#305MicroFish91 merged 10 commits intomainfrom
MicroFish91 merged 10 commits intomainfrom
Conversation
bwateratmsft
approved these changes
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses: #304
Will add a separate PR to address third party registry steps like those associated with Docker Hub.
For this PR, the implementation I've added looks at the current container app image and checks to see if the values can be re-applied for the new deployment. If it can, it will suggest the value by extracting it and placing it at the top of the list of quick picks and add the description:
(currently deployed). (I'm very open to whatever labels you guys prefer instead.. I am not great with names/descriptions 😅)Example:
This is different that
(recently used)in that it always uses the context of the current Container App rather than using your last pick choice.If the suggested pick is not found, it will default to the old way of categorizing via
(recently used).