Decouple editTargetPort from createContainerApp#371
Merged
MicroFish91 merged 8 commits intomainfrom May 17, 2023
Merged
Conversation
MicroFish91
commented
May 16, 2023
MicroFish91
commented
May 16, 2023
| workCompleted: string | ||
| } | ||
|
|
||
| export abstract class IngressUpdateBaseStep<T extends IContainerAppContext> extends AzureWizardExecuteStep<T> { |
Contributor
Author
There was a problem hiding this comment.
This step is meant to (eventually) completely replace the use of updateIngressSettings.ts
Contributor
Author
|
Also FYI, checks are failing right now because the linter does not like the temporarily included |
bwateratmsft
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.