-
Notifications
You must be signed in to change notification settings - Fork 17
Add revision draft support (single revision mode) #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
848165c
Impl migration
MicroFish91 24e27fa
Single revision only (reduce amount of code to review)
MicroFish91 a58ee13
Remove unused commands
MicroFish91 a62d704
delay util
MicroFish91 0ef0044
Fix editContainerApp view context
MicroFish91 3ae11b1
Fix copy paste
MicroFish91 c133338
Remove more multiple revisions mode changes
MicroFish91 9bf039f
Update method scope
MicroFish91 f79c419
Nit
MicroFish91 02dc1a4
Import type
MicroFish91 6e5ff2f
Comment out multiple revisions specific impl
MicroFish91 73a82b1
readonly
MicroFish91 60737de
First pass review changes
MicroFish91 a66b3ff
baseRevisionName getter
MicroFish91 67a5079
Non important edge case
MicroFish91 ea677ed
Comment
MicroFish91 0b07f91
deep-eql
MicroFish91 6621678
.has()
MicroFish91 0256b14
Merge with main
MicroFish91 242b6ad
Fix merge issues
MicroFish91 ebe802e
Merge branch 'main' of https://github.com/microsoft/vscode-azureconta…
MicroFish91 91a7cdb
More feedback
MicroFish91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /*--------------------------------------------------------------------------------------------- | ||
| * Copyright (c) Microsoft Corporation. All rights reserved. | ||
| * Licensed under the MIT License. See License.txt in the project root for license information. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
|
|
||
| import { KnownActiveRevisionsMode } from "@azure/arm-appcontainers"; | ||
| import type { IActionContext } from "@microsoft/vscode-azext-utils"; | ||
| import { ext } from "../extensionVariables"; | ||
| import type { ContainerAppItem } from "../tree/ContainerAppItem"; | ||
| import { localize } from "../utils/localize"; | ||
| import { pickContainerApp } from "../utils/pickContainerApp"; | ||
|
|
||
| export async function editContainerApp(context: IActionContext, node?: ContainerAppItem): Promise<void> { | ||
| node ??= await pickContainerApp(context); | ||
|
|
||
| if (node.containerApp.revisionsMode !== KnownActiveRevisionsMode.Single) { | ||
| throw new Error(localize('revisionModeError', 'The issued command can only be executed in single revision mode.')); | ||
|
nturinski marked this conversation as resolved.
Outdated
MicroFish91 marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| await ext.revisionDraftFileSystem.editRevisionDraft(node); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.