Add deployRevisionDraft support for all revision modes#414
Merged
MicroFish91 merged 8 commits intomainfrom Jul 28, 2023
Merged
Conversation
bwateratmsft
approved these changes
Jul 27, 2023
Contributor
Author
|
Made a few additional changes since the original (demo). What's been added:
|
MicroFish91
force-pushed
the
mwf/revision-draft-alt-4
branch
from
c8e9c33 to
516ef8f
Compare
MicroFish91
force-pushed
the
mwf/revision-draft-alt-4
branch
from
516ef8f to
876f2e4
Compare
nturinski
reviewed
Jul 28, 2023
| export class DeployRevisionDraftConfirmStep extends AzureWizardPromptStep<IDeployRevisionDraftContext> { | ||
| public async prompt(context: IDeployRevisionDraftContext): Promise<void> { | ||
| await context.ui.showWarningMessage( | ||
| localize('deployRevisionWarning', 'This will deploy a new revision to container app "{0}".', context.containerApp?.name), |
Member
There was a problem hiding this comment.
I think we should steer away from the word "revision" since we don't really expose that anywhere else. We should probably just have something to the effect that we're "Deploying to container app" or "Updating container app" or something.
MicroFish91
force-pushed
the
mwf/revision-draft-alt-4
branch
from
2b8b9bd to
8d0669a
Compare
nturinski
reviewed
Jul 28, 2023
| export class DeployRevisionDraftConfirmStep extends AzureWizardPromptStep<IDeployRevisionDraftContext> { | ||
| public async prompt(context: IDeployRevisionDraftContext): Promise<void> { | ||
| await context.ui.showWarningMessage( | ||
| localize('deployRevisionWarning', 'This will deploy any unsaved changes to container app "{0}".', context.containerApp?.name), |
Member
There was a problem hiding this comment.
I think we should probably say something more similar to deploy.
Are you sure you want to deploy changes to "{0}"? This will overwrite your previous deployment.
nturinski
reviewed
Jul 28, 2023
| await context.ui.showWarningMessage( | ||
| localize('deployRevisionWarning', 'This will deploy any unsaved changes to container app "{0}".', context.containerApp?.name), | ||
| { modal: true }, | ||
| { title: localize('continue', 'Continue') } |
Member
There was a problem hiding this comment.
I would have this title be "Deploy"
nturinski
reviewed
Jul 28, 2023
| const containerAppEnvelope = await getContainerEnvelopeWithSecrets(context, context.subscription, containerApp); | ||
| containerAppEnvelope.template = nonNullProp(context, 'template'); | ||
|
|
||
| const creatingRevision: string = localize('creatingRevision', 'Creating revision...'); |
nturinski
reviewed
Jul 28, 2023
|
|
||
| if (containerApp.revisionsMode === KnownActiveRevisionsMode.Multiple) { | ||
| // Display the name of the newly created revision when in multiple revisions mode | ||
| context.activityTitle = localize('deployRevision', 'Deploy revision "{0}" to container app "{1}"', updatedContainerApp.latestRevisionName, containerApp.name); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #311
Demo (Same as the one shown in previous revision draft PRs)