Update deleteManagedEnvironment activity messages and general housekeeping#431
Update deleteManagedEnvironment activity messages and general housekeeping#431MicroFish91 merged 5 commits intomainfrom
deleteManagedEnvironment activity messages and general housekeeping#431Conversation
MicroFish91
changed the title
deleteManagedEnvironment activity and housekeepingdeleteManagedEnvironment activity messages and general housekeeping
| public async execute(context: IDeleteManagedEnvironmentContext, progress: Progress<{ message?: string | undefined; increment?: number | undefined }>): Promise<void> { | ||
| const client: ContainerAppsAPIClient = await createContainerAppsAPIClient([context, context.subscription]); | ||
|
|
||
| const deleting: string = localize('deletingManagedEnv', 'Deleting environment... this may take several minutes...'); |
There was a problem hiding this comment.
I prefer having the name in here since it takes so long. Also don't like the added ellipsis at the end.
There was a problem hiding this comment.
Wait, do we really want to display the name again (it's already showing in the title right next to it)? I also tried without ellipses, and it looks kind of weird to me. What phrase are you looking at as the replacement description?
There was a problem hiding this comment.
Ahhh sorry, I forgot that's how it looked on the activity log.
Maybe we just chnage it to This may take a few minutes...?
There was a problem hiding this comment.
I'm also cool with that, but let me give you some additional context just in case.
The reason I kept the Deleting environment... portion prefixed was because the description could first show the Deleting container app {x}... message if the managed environment has children - so keeping it does let the user know what the current step is actually doing and lets the user know that the process has progressed. That said, it is a bit long with it, so I'm happy to remove it... I personally don't have very strong opinions between these two descriptions
2 participants
Closes #389
From:
To:
