Skip to content

Add Create Azure Container Registry command#435

Merged
motm32 merged 5 commits intomainfrom
meganmott/addAcr
Aug 25, 2023
Merged

Add Create Azure Container Registry command#435
motm32 merged 5 commits intomainfrom
meganmott/addAcr

Conversation

@motm32
Copy link
Copy Markdown
Contributor

@motm32 motm32 commented Aug 15, 2023

Part of #425.

Copy link
Copy Markdown
Contributor

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to use Docker's existing create ACR command?

@nturinski
Copy link
Copy Markdown
Member

Don't want to use Docker's existing create ACR command?

The main reason we don't want to use Docker for this is because the code-to-cloud scenario should be enabled in VS Code for the Web which we wouldn't be able to support if we use the Docker extension.

@bwateratmsft
Copy link
Copy Markdown
Contributor

That's a very good reason. 😄

@motm32 motm32 marked this pull request as ready for review August 17, 2023 23:10
@motm32 motm32 requested a review from a team as a code owner August 17, 2023 23:10
Comment thread package.nls.json Outdated
Comment thread src/commands/deployImage/imageSource/containerRegistry/acr/createAcr/createAcr.ts Outdated
@motm32 motm32 merged commit 35eaafd into main Aug 25, 2023
@motm32 motm32 deleted the meganmott/addAcr branch August 25, 2023 18:40
@microsoft microsoft locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants