Updates related to EnvironmentVariablesListStep #450
Conversation
…inerapps into mwf/deployWorkspaceProject-I
…crosoft/vscode-azurecontainerapps into mwf/deployWorkspaceProject-III
MicroFish91
changed the base branch from
main
to
mwf/deployWorkspaceProject-III
MicroFish91
force-pushed
the
mwf/deployWorkspaceProject-IV
branch
from
2d7d0fa to
73204e9
Compare
MicroFish91
force-pushed
the
mwf/deployWorkspaceProject-IV
branch
from
f76cb4d to
541af13
Compare
nturinski
left a comment
nturinski
left a comment
There was a problem hiding this comment.
Somewhat related to this PR-- do you know if you hit "skip for now", does the container app keep its existing environment settings or does that get reset?
|
I think currently it would just have no environment variables if you hit "skip for now". Think it would be worth adding a logic path to carry over the settings without the .env? |
|
Yeah, this came up in a service connector meeting. Deploying to a container app and resetting all the environment settings is a pretty bad experience because it'd break a lot of things that were previously working. I don't know if we should have another option that says "use existing settings" or, if you just skip it, it preserves whatever settings were on the app. |
| // Todo: It might be nice to add a direct command to update just the environment variables rather than having to suggest to re-run the entire command again | ||
| private outputLogs(_context: ImageSourceBaseContext, setEnvironmentVariableOption: SetEnvironmentVariableOption): void { | ||
| if (setEnvironmentVariableOption !== SetEnvironmentVariableOption.ProvideFile) { | ||
| // context.activityChildren?.push( |
There was a problem hiding this comment.
Why did you comment out of the activity log stuff? Not hooked up yet?
There was a problem hiding this comment.
Yup, going to hook up all the activity children logic in one PR later down the line because it's a bit more involved than just these item pushes... figured it's easier to review together in one wombo combo
That makes sense, I'll open an issue |
2 participants
Continuation of: #425
Consolidate two steps into one step:
Add/use static method for checking if workspace has an env file