Add additional entry-points for deployWorkspaceProject#482
Merged
MicroFish91 merged 12 commits intomainfrom Oct 12, 2023
Merged
Add additional entry-points for deployWorkspaceProject#482MicroFish91 merged 12 commits intomainfrom
deployWorkspaceProject#482MicroFish91 merged 12 commits intomainfrom
Conversation
MicroFish91
changed the title
deployWorkspaceProjectdeployWorkspaceProject
nturinski
reviewed
Oct 11, 2023
nturinski
reviewed
Oct 11, 2023
nturinski
reviewed
Oct 11, 2023
MicroFish91
commented
Oct 11, 2023
nturinski
reviewed
Oct 11, 2023
Contributor
Author
|
New pop-up confirmation:
|
nturinski
approved these changes
Oct 12, 2023
Member
nturinski
left a comment
nturinski
left a comment
There was a problem hiding this comment.
Approving ahead of time because i'm going to be out of office and don't want to block
Member
I think it'd be good to have a button to override old settings. |
Contributor
Author
Already got it covered with Let me know if you see any issues later and I can put in additional changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deployWorkspaceProjectcurrently only exists as a workspace and command-palette command.This PR adds additional entry-points to the following tree items:
ContainerAppItemUpdated:
ManagedEnvironmentItemIt also checks to ensure no conflicts exist between existing workspace settings vs. the tree item selected (else it throws an error).
I also separated out some of the code that originally existed in
getDefaultContainerAppResourcesinto separate files.