Fix command palette support for restartRevision#487
Merged
MicroFish91 merged 1 commit intomainfrom Oct 19, 2023
Merged
Conversation
|
|
||
| export async function executeRevisionOperation(context: IActionContext, node: ContainerAppItem | RevisionItem | undefined, operation: RevisionOperation): Promise<void> { | ||
| const item = node ?? await pickContainerApp(context); | ||
| if (!node) { |
Member
There was a problem hiding this comment.
What if the node is a ContainerAppItem but it's in multiple revision mode? Do we still need to pick a revision in that case?
Contributor
Author
There was a problem hiding this comment.
I think we should be good with this scenario because the command is removed from the context menu when in multiple revisions mode. When in multiple revisions mode the command should only be executable from either no node (command-palette) or a RevisionItem!
alexweininger
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #486