Skip to content

Add an entry-point to view ACR build image error logs in the activity log#576

Merged
MicroFish91 merged 17 commits intomainfrom
mwf/build-image-log
Jan 3, 2024
Merged

Add an entry-point to view ACR build image error logs in the activity log#576
MicroFish91 merged 17 commits intomainfrom
mwf/build-image-log

Conversation

@MicroFish91
Copy link
Copy Markdown
Contributor

@MicroFish91 MicroFish91 commented Nov 27, 2023

Requires a couple updates to the Azure Tools shared package first, will provide links soon.

Review Notes:

  • The bulk of the implementation you'll want to inspect is shown in BuildImageStep.ts
  • Less important, but also worth inspecting - openAcrBuildLogs.ts
  • Rest is just reconfiguring imports and scaffolding the new command

Closes #570

Adds ability to display additional nested children, see new logs item support shown below:

image

Clicking the logs item will open up the logs like so:

image

@MicroFish91 MicroFish91 marked this pull request as ready for review December 29, 2023 18:48
@MicroFish91 MicroFish91 requested a review from a team as a code owner December 29, 2023 18:49
@MicroFish91
Copy link
Copy Markdown
Contributor Author

MicroFish91 commented Dec 29, 2023

Shared package upgraded and incorporated, ready for review! :)
(most of the line changes registered are from the package-lock)

Comment thread src/commands/image/imageSource/buildImageInAzure/BuildImageStep.ts Outdated
Comment thread src/commands/image/imageSource/buildImageInAzure/BuildImageStep.ts Outdated
Copy link
Copy Markdown
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small nits, rest looks good.

@MicroFish91 MicroFish91 merged commit 2eaf157 into main Jan 3, 2024
@MicroFish91 MicroFish91 deleted the mwf/build-image-log branch January 3, 2024 18:56
@microsoft microsoft locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Find a better place to display ACR build image logs

2 participants